ServiceDiscovery failure

[sleipnir]

During some tests @marcellanz found this error message:

[marcellanz]

This has happened with a v0.2.0 versioned protocol and I think the renamed gRPC (uppercase) service names. I'll have to double check that.

[sleipnir]

This has happened with a v0.2.0 versioned protocol and I think the renamed gRPC (uppercase) service names....

It seems that this version v0.2.0 was not in the Master of CloudState and consequently is not in the master of Permastate

[marcellanz]

This is my fault. I've used a PR version from cloudstate. I'll revert and try again.

[sleipnir]

No problem. Take you're time

[marcellanz]

@sleipnir I've retested and all is fine. I've tested initially with the state of this cloudstateio/cloudstate#511 on the main CS project where we tested to name gRPC services by best practice.

[sleipnir]

@marcellanz Can we merge this PR (cloudstateio/cloudstate#511) into the Permastate master and make a cherry pick of the commits for the main branch? So we would start the development of #19 already with the protocol following the best practices.
Wdyt?

[marcellanz]

@sleipnir the PR is clearly not yet merged there; so we would be "incompatible" with CS v0.2.0. We would then start with an incompatible protocol and have to maintain it, right? I'm open for it, but it means versioning from our side on all levels.

[sleipnir]

@marcellanz I don't know what would be better, it seems to me that this is a step that will be without return, but it also seems to me that LB will have to make this change there at some point.
Let's be cautious, I will use what we have available in the master for now, it doesn't seem like a problem to change this in the future, basically we would have to recompile the proto files and some superficial change in the source code.

Ok?

[marcellanz]

@sleipnir I agree.

[sleipnir]

@marcellanz and @ralphlaude How will we implement CloudState's 0.2.0 protocol in the future if it becomes standard and to maintain compatibility with the current protocol then I will be closing this issue and opening others as needed in the future.
But reopen if deemed necessary