Skip to content
This repository has been archived by the owner on Aug 26, 2022. It is now read-only.

Start wip to reflect user function grpc server #19

Merged
merged 29 commits into from
Mar 25, 2021

Conversation

sleipnir
Copy link
Member

No description provided.

@sleipnir
Copy link
Member Author

This is a Draft.
Don't merge

@sleipnir sleipnir requested review from ralphlaude and marcellanz and removed request for marcellanz and ralphlaude March 14, 2021 20:32
This was linked to issues Mar 15, 2021
@sleipnir sleipnir mentioned this pull request Mar 17, 2021
default: 8080, map: &String.to_integer/1, required: false},
{:user_function_uds_enable, "PROXY_UDS_MODE", default: false, required: false},
{:user_function_sock_addr, "PROXY_UDS_ADDRESS",
default: "/var/run/cloudstate.sock", required: false},
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why is it needed /var/run/cloudstate.sock?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Our proxy has the ability to communicate with the user role via unix domain sockets, in theory faster than going over the network. This can be seen and tested using the Python support language (not via branch master). There was a long discussion on this topic in some cloudstate forum (gitter or github) that I don't remember exactly anymore.

This is a path to the domain socket in the host

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I remember the discussion regarding the unix domain sockets. Thanks for the explanation :)

@@ -0,0 +1,228 @@
// Copyright 2020 Google LLC
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice authentication with pb 👍

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In fact, this only exists to avoid unnecessary compilations at run time, so it is included at compile time. Look at here

|> Flow.filter(&skip_well_known_type/1)

@sleipnir
Copy link
Member Author

@marcellanz @ralphlaude I think we can close this one and open another one just for grpc reflection to complete the items that come from #13

Massa Proxy automation moved this from In progress to Reviewer approved Mar 25, 2021
Copy link
Member

@marcellanz marcellanz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome stuff Adriano, really great. 🚀❤️

@sleipnir sleipnir merged commit 42508d4 into master Mar 25, 2021
Massa Proxy automation moved this from Reviewer approved to Done Mar 25, 2021
@ralphlaude
Copy link
Collaborator

Great :) @sleipnir 🚀

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request platform
Projects
Massa Proxy
  
Done
3 participants