Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing ifdef for umpire #831

Merged
merged 2 commits into from
Apr 24, 2023
Merged

Add missing ifdef for umpire #831

merged 2 commits into from
Apr 24, 2023

Conversation

simonpintarelli
Copy link
Collaborator

@simonpintarelli simonpintarelli commented Apr 24, 2023

spack install sirius~memory_pool

failed to compile because a missing ifdef in memory_pool::clear.

Not related, but struct Real has been defined twice. I've included the header typedefs.hpp in acc_common.hpp and removed the duplicate.

Copy link
Collaborator

@toxa81 toxa81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@toxa81 toxa81 merged commit 2f32150 into develop Apr 24, 2023
@toxa81 toxa81 deleted the fix-ifdef branch April 25, 2023 22:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants