Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable MPI settings for parallel verification tests #835

Merged
merged 2 commits into from
May 11, 2023

Conversation

RMeli
Copy link
Collaborator

@RMeli RMeli commented May 2, 2023

spack build-env sirius +cuda +fortran +scalapack +tests -- bash

cmake \
    -DUSE_CUDA=on -DCMAKE_CUDA_ARCHITECTURES=89 \
    -DCMAKE_EXPORT_COMPILE_COMMANDS=1 \
    -DUSE_MEMORY_POOL=off \
    -DUSE_SCALAPACK=on \ 
    -DBUILD_TESTING=on \
    -DMPIEXEC_EXECUTABLE=mpiexec \
    -DMPIEXEC_NUMPROC_FLAG="-n" \
    -DMPIEXEC_MAX_NUMPROCS=4 \
    ..

make -j 6

export OMP_NUM_THREADS=6
ctest

100% tests passed, 0 tests failed out of 153

Label Time Summary:
integration_test cpu_band_parallel       = 230.57 sec*proc (24 tests)
integration_test cpu_serial              = 221.24 sec*proc (24 tests)
integration_test gpu_band_parallel       = 544.59 sec*proc (24 tests)
integration_test gpu_k_point_parallel    = 218.36 sec*proc (24 tests)
integration_test gpu_serial              = 204.90 sec*proc (24 tests)

Total Test time (real) = 1445.67 sec

@simonpintarelli
Copy link
Collaborator

cscs-ci run default

@electronic-structure
Copy link
Owner

I need to add you to cicd white list,I'll do it tomorrow

@toxa81
Copy link
Collaborator

toxa81 commented May 4, 2023

@RMeli, @mtaillefumier and @simonpintarelli are whitelisted, you can submit cscs-ci run default

@RMeli
Copy link
Collaborator Author

RMeli commented May 10, 2023

cscs-ci run default

@RMeli
Copy link
Collaborator Author

RMeli commented May 10, 2023

I changed this PR in a way that is does not interfere with CI. Users can now use -DMPIRUN to specify how to run MPI tests via ctest.

cmake \
    -DUSE_CUDA=on -DCMAKE_CUDA_ARCHITECTURES=89 \
    -DCMAKE_EXPORT_COMPILE_COMMANDS=1 \
    -DUSE_MEMORY_POOL=off \
    -DUSE_SCALAPACK=on \ 
    -DBUILD_TESTING=on \
    -DMPIRUN="mpiexec -n 4" \
    ..

make -j 6

export OMP_NUM_THREADS=6
ctest

Additionally, GPU tests are enabled only if USE_CUDA or USE_ROCM are set.

@RMeli RMeli requested a review from toxa81 May 10, 2023 12:00
Copy link
Collaborator

@toxa81 toxa81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@toxa81
Copy link
Collaborator

toxa81 commented May 11, 2023

@simonpintarelli If it's OK to merge, I'll do it

@simonpintarelli simonpintarelli merged commit 8bd6f4f into electronic-structure:develop May 11, 2023
3 checks passed
@RMeli RMeli deleted the cmake branch May 22, 2023 20:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants