ChooseProjectButton: Deactivate all project rows before selecting new active project #1414
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I can still produce the issue: |
|
That's weird - I was sure it was fixed but now it isnt 😞 |
|
This proving trickier than expected to fix in all circumstances so I'm going to convert to draft after have a deeper rethink. |
|
@colinkiama Hopefully fixed now! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1413
Although the list box is in SINGLE selection mode, the radio buttons in the project rows are not affected by this so have to be explicitly unchecked when a new active project is chosen.
This PR makes the GitManager the source of truth regarding the active_project_path. Some public access is removed. It also simplifies the ProjectRows and makes sure they remain grouped even when projects are removed and are re-added.