Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Put branch name on separate line #1423

Merged
merged 5 commits into from
Mar 14, 2024
Merged

Conversation

jeremypw
Copy link
Collaborator

Fixes #574

Makes current branch visible without excessive sidebar width when both project and branch have long names
Screenshot from 2024-02-22 11 03 04

zeebok
zeebok previously approved these changes Feb 22, 2024
Copy link
Contributor

@zeebok zeebok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good. Is this something that needs to be run by UX?

@jeremypw jeremypw requested a review from a team February 23, 2024 15:34
@jeremypw
Copy link
Collaborator Author

@zeebok. Thanks for the review. Not sure if the design change is significant but I'll request a review from UX anyway. I wanted to wrap the text but it doesn't seem possible in SourceList so I had to hard code two lines.

Copy link
Member

@danirabbit danirabbit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the newline for the branch name makes sense here, but I'm -1 on making the project name even larger

@jeremypw
Copy link
Collaborator Author

I find it useful to have the project names more prominent and easily readable but maybe I need new glasses ...

@jeremypw
Copy link
Collaborator Author

I have left this project name size slightly increased as it was smaller than the file items before (!). I really think it needs to stand out at least a little. This is how it looks now:
Screenshot from 2024-03-13 19 45 53

@danirabbit danirabbit merged commit 81b4869 into master Mar 14, 2024
6 checks passed
@danirabbit danirabbit deleted the jeremypw/wrap-project-header branch March 14, 2024 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

UX: git branch not readable if dir name is too long.
3 participants