Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(jetty): upgrade to 10.0.21 #1683

Merged
merged 8 commits into from
Jul 10, 2024
Merged

build(jetty): upgrade to 10.0.21 #1683

merged 8 commits into from
Jul 10, 2024

Conversation

jo-elimu
Copy link
Member

@jo-elimu jo-elimu commented Jul 7, 2024

closes #1656

@jo-elimu jo-elimu self-assigned this Jul 7, 2024
Copy link

codecov bot commented Jul 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 15.03%. Comparing base (5eec8c9) to head (411a036).

Additional details and impacted files
@@            Coverage Diff            @@
##               main    #1683   +/-   ##
=========================================
  Coverage     15.03%   15.03%           
  Complexity      452      452           
=========================================
  Files           249      249           
  Lines          7760     7760           
  Branches        812      812           
=========================================
  Hits           1167     1167           
  Misses         6541     6541           
  Partials         52       52           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jo-elimu jo-elimu marked this pull request as ready for review July 9, 2024 06:38
@jo-elimu jo-elimu requested a review from a team as a code owner July 9, 2024 06:38
Copy link
Contributor

coderabbitai bot commented Jul 9, 2024

Walkthrough

This update enhances the documentation by adding deployment instructions to DEPLOY.md for a CentOS 9 Stream production environment. The changes ensure clarity and consistency in both README.md and INSTALL.md, including references to the new deployment details. Additionally, a configuration file for Jetty's settings on CentOS 9 Stream is included to support the deployment process.

Changes

Files Change Summary
INSTALL.md Added a note directing users to deployment instructions in DEPLOY.md.
README.md Updated documentation links and added a section for deploying the web app on a production server.
src/main/config/DEPLOY.md Added detailed deployment instructions for a CentOS 9 Stream environment.
src/main/config/centos-stream-9/.../jetty Introduced Jetty configuration settings, establishing paths for JETTY_HOME and JETTY_BASE.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@jo-elimu jo-elimu requested review from SnehaHS65 and venkatesh2k3 and removed request for vrudas, eymaal and sshivaditya2019 July 9, 2024 06:39
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Outside diff range and nitpick comments (5)
src/main/config/DEPLOY.md (5)

7-7: Add a missing comma after "In this example".

A comma is required to improve readability.

- In this example we will be using [CentOS](https://www.centos.org),
+ In this example, we will be using [CentOS](https://www.centos.org),
Tools
LanguageTool

[typographical] ~7-~7: It appears that a comma is missing.
Context: ...erver. ## Operating System 🔆 In this example we will be using [CentOS](https://www.c...

(DURING_THAT_TIME_COMMA)


37-37: Format the bare URL.

To conform with Markdownlint rules, format the bare URL.

- You can find the download links for each release at https://jetty.org/download.html
+ You can find the download links for each release at [Jetty Downloads](https://jetty.org/download.html)
Tools
Markdownlint

37-37: null
Bare URL used

(MD034, no-bare-urls)


120-120: Format the bare URL.

To conform with Markdownlint rules, format the bare URL.

- Configure a YUM repo entry for your OS at https://mariadb.org/download/?t=repo-config.
+ Configure a YUM repo entry for your OS at [MariaDB Repository Configuration](https://mariadb.org/download/?t=repo-config).
Tools
Markdownlint

120-120: null
Bare URL used

(MD034, no-bare-urls)


169-171: Fix the code block style for SQL commands.

To conform with Markdownlint rules, use indented code blocks for SQL commands.

- ```sql
- CREATE DATABASE `webapp-HIN` CHARACTER SET utf8mb4 COLLATE utf8mb4_bin;
- ```

+     CREATE DATABASE `webapp-HIN` CHARACTER SET utf8mb4 COLLATE utf8mb4_bin;
Tools
Markdownlint

169-169: Expected: indented; Actual: fenced
Code block style

(MD046, code-block-style)


175-179: Fix the code block style for SQL commands.

To conform with Markdownlint rules, use indented code blocks for SQL commands.

- ```sql
- USE `webapp-HIN`;
- CREATE USER '**********'@'localhost' IDENTIFIED BY '**********';
- GRANT ALL ON `webapp-HIN`.* TO '**********'@'localhost';
- ```

+     USE `webapp-HIN`;
+     CREATE USER '**********'@'localhost' IDENTIFIED BY '**********';
+     GRANT ALL ON `webapp-HIN`.* TO '**********'@'localhost';
Tools
Markdownlint

175-175: Expected: indented; Actual: fenced
Code block style

(MD046, code-block-style)

@jo-elimu jo-elimu merged commit adc7c18 into main Jul 10, 2024
10 checks passed
@jo-elimu jo-elimu deleted the 1656-jetty-10.0.21 branch July 10, 2024 08:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade to latest version of Jetty 10.x
3 participants