Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: #1684 Renamed package ai.elmu.model to ai.elmu.entity #1686

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

chore: #1684 Renamed package ai.elmu.model to ai.elmu.entity #1686

wants to merge 2 commits into from

Conversation

diptechexpo
Copy link

@diptechexpo diptechexpo commented Jul 7, 2024 •
edited by jo-elimu
Loading

This pull request addresses issue #1684 by renaming the package ai.elmu.model to ai.elmu.entity.

closes #1684

@diptechexpo diptechexpo requested a review from a team as a code owner July 7, 2024 20:28
@codecov Codecov
Copy link

codecov bot commented Jul 8, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 15.03%. Comparing base (f42424d) to head (35bc4bd).

Files Patch % Lines
...c/main/java/ai/elimu/entity/enums/CodeLicense.java 0.00% 1 Missing ⚠️
.../ai/elimu/web/servlet/CustomDispatcherServlet.java 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff            @@
##               main    #1686   +/-   ##
=========================================
  Coverage     15.03%   15.03%           
  Complexity      452      452           
=========================================
  Files           249      249           
  Lines          7760     7760           
  Branches        812      812           
=========================================
  Hits           1167     1167           
  Misses         6541     6541           
  Partials         52       52

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@diptechexpo
elimu-ai#1684 addressed review comment to change hardcoded package na…
35bc4bd 
…me ai.elimu.model by dynaically pulling package name using BaseEntity class
diptechexpo
diptechexpo commented Jul 8, 2024
View reviewed changes
Copy link
Author

@diptechexpo diptechexpo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Incorporated review comments. Kindly re-review.

jo-elimu
jo-elimu approved these changes Jul 8, 2024
View reviewed changes
Copy link
Member

@jo-elimu jo-elimu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, ready to merge! 🙂

@jo-elimu
Copy link
Member

jo-elimu commented Jul 9, 2024

@diptechexpo Please merge your PR 🙂

@jo-elimu
Copy link
Member

@diptechexpo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jo-elimu jo-elimu jo-elimu approved these changes

@coderabbitai coderabbitai[bot] coderabbitai approved these changes

@vrudas vrudas Awaiting requested review from vrudas vrudas is a code owner automatically assigned from elimu-ai/codeowners-web

@tomaszsmy tomaszsmy Awaiting requested review from tomaszsmy tomaszsmy is a code owner automatically assigned from elimu-ai/codeowners-web

Assignees

@diptechexpo diptechexpo

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Rename ai.elimu.model package
2 participants
@diptechexpo @jo-elimu