Policy::Logging: Fix crash on invalid config.

If the logging config is not correct,operations are not defined,the loop will not work and it'll crash. Fix 3scale#1165 Fix THREESCALE-4605 Signed-off-by: Eloy Coto <[email protected]>
eloycoto · Mar 7, 2020 · 1331dc9 · 1331dc9
1 parent e71467f
commit 1331dc9
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 1 deletion.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -7,6 +7,7 @@ and this project adheres to [Semantic Versioning](http://semver.org/).
 ## [3.8.0-alpha2] - 2019-02-18
 
 - Fixed naming issues in policies [THREESCALE-4150](https://issues.jboss.org/browse/THREESCALE-4150) [PR #1167](https://github.com/3scale/APIcast/pull/1167)
+- Fixed issues on invalid config in logging policy [THREESCALE-4605](https://issues.jboss.org/browse/THREESCALE-4605) [PR #1168](https://github.com/3scale/APIcast/pull/1168)
 
 ## [3.7.0-alpha2]
 

diff --git a/gateway/src/apicast/policy/logging/logging.lua b/gateway/src/apicast/policy/logging/logging.lua
@@ -56,7 +56,7 @@ function _M:load_condition(config)
 
   ngx.log(ngx.DEBUG, 'Enabling extended log with conditions')
   local operations = {}
-  for _, operation in ipairs(config.condition.operations) do
+  for _, operation in ipairs(config.condition.operations or {}) do
     table.insert( operations,
       Operation.new(
         operation.match, operation.match_type,