Is fix (#35)

* fix for composition with other components * add changeset
embellishing · May 26, 2024 · 630ffbd · 630ffbd
1 parent 6a6b56b
commit 630ffbd
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 2 deletions.
diff --git a/.changeset/flat-garlics-taste.md b/.changeset/flat-garlics-taste.md
@@ -0,0 +1,5 @@
+---
+"@embellish/react": patch
+---
+
+Fix for component composition via `is` prop.
diff --git a/packages/react/src/index.d.ts b/packages/react/src/index.d.ts
@@ -38,7 +38,9 @@ export function createComponent<
   const DisplayName extends string,
   StyleProps,
   Conds,
-  DefaultIs extends keyof JSX.IntrinsicElements = "div",
+  DefaultIs extends
+    | keyof JSX.IntrinsicElements
+    | React.JSXElementConstructor<any> = "div", // eslint-disable-line @typescript-eslint/no-explicit-any
 >(config: {
   displayName: DisplayName & ValidComponentDisplayName<DisplayName>;
   defaultIs?: DefaultIs;
@@ -51,7 +53,7 @@ export function createComponent<
 }): <
   Is extends
     | keyof JSX.IntrinsicElements
-    | React.JSXElementConstructor<unknown> = DefaultIs,
+    | React.JSXElementConstructor<any> = DefaultIs, // eslint-disable-line @typescript-eslint/no-explicit-any
   LocalConditionName extends string = never,
 >(
   props: {