Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove namespaces #43

Merged
merged 6 commits into from
Jun 4, 2024
Merged

Remove namespaces #43

merged 6 commits into from
Jun 4, 2024

Conversation

nsaunders
Copy link
Contributor

@nsaunders nsaunders commented Jun 4, 2024

I've decided that the component display namespace, as well as the initial namespace for style props, are probably unnecessary given that this composition pattern works with a basic as prop:

<ButtonBase
  as={(props: ComponentPropsWithRef<"a">) => (
    <TextBase as="a" {...props} fontSize="sm" hover:fontSize="lg" />
  )}
  bg="black"
  fg="white"
  hover:bg="#333"
  href="https://google.com/"
>
  Hello from Box
</ButtonBase>

Copy link

changeset-bot bot commented Jun 4, 2024

🦋 Changeset detected

Latest commit: 1cfaa86

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@embellish/react Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@nsaunders nsaunders merged commit 4f45057 into master Jun 4, 2024
1 check passed
@nsaunders nsaunders deleted the remove-namespaces branch June 4, 2024 01:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant