Generate a JSONAPISerializer to stop relying on the defaultSerializer behavior #218
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey thanks for the contribution 🎉 I was wondering if it were possible to add an application serializer to Guidemaker that would solve this issue? 🤔 Guidemaker is the core-addon that powers the cli-guides, as you can see there is no code in the Ember App in this repo (other than now your Application Serializer 😂) because it is all being provided by Guidemaker: https://github.com/empress/guidemaker |
|
Yea sorry, I didn't really look into the details 😄. I just noticed the warnings in the console and "fixed" it without looking at the rest of the codebase. I just found this issue: empress/guidemaker#34 and a related PR which covers it already I think? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Deprecation information: https://deprecations.emberjs.com/ember-data/v3.x/#toc_ember-data-default-serializers