Add Android 6.0 permissions #33
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emj365
reviewed
Oct 27, 2016
| ```bash | ||
| $ cordova plugin add cordova-plugin-audio-recorder-api | ||
| ``` | ||
|
|
|
Please ignore that readme.md change. It is not required. |
|
Seems like theres 3 different pull requests for fixes for the new permissions. @emj365, where are we with this? Definitely important for the life of this plugin, and for what I personally believe to be the best audio capture plugin for cordova. |
Update AudioRecorderAPI.m
if we already have all permissions and we call dopermissions from the JS app, we get stuck as no response is sent.
Fixing issue where no implementation of doPermissions in AudioRecorderAPI.m breaks iOS when called.
…oRecorderAPI.m breaks iOS when called."
Revert "Fixing issue where no implementation of doPermissions in AudioRecorderAPI.m breaks iOS when called."
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also increases the iOS audio quality basedon KevinWang15's changes.