Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: gRPC Access Log Service (ALS) sink #3626

Merged
merged 20 commits into from
Jul 3, 2024
Merged

feat: gRPC Access Log Service (ALS) sink #3626

merged 20 commits into from
Jul 3, 2024

Conversation

zirain
Copy link
Contributor

@zirain zirain commented Jun 19, 2024

replace #3062

@zirain zirain requested a review from a team as a code owner June 19, 2024 03:56
@codecov Codecov
Copy link

codecov bot commented Jun 19, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 73.77049% with 32 lines in your changes missing coverage. Please review.

Project coverage is 68.90%. Comparing base (1cf3016) to head (af76bd6).

Files Patch % Lines
internal/provider/kubernetes/controller.go 0.00% 16 Missing ⚠️
internal/xds/translator/accesslog.go 78.94% 11 Missing and 1 partial ⚠️
internal/gatewayapi/listener.go 93.93% 1 Missing and 1 partial ⚠️
internal/provider/kubernetes/indexers.go 87.50% 1 Missing and 1 partial ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #3626      +/-   ##
==========================================
+ Coverage   68.84%   68.90%   +0.06%     
==========================================
  Files         175      175              
  Lines       21524    21602      +78     
==========================================
+ Hits        14818    14885      +67     
- Misses       5632     5637       +5     
- Partials     1074     1080       +6

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zirain
lint
f3338b3 
Signed-off-by: zirain <[email protected]>
@zirain
update
55acdc9 
Signed-off-by: zirain <[email protected]>
@zirain
e2e
14c3de9 
Signed-off-by: zirain <[email protected]>
@zirain
fix test
1625b31 
Signed-off-by: zirain <[email protected]>
@zirain
Copy link
Contributor Author

zirain commented Jun 22, 2024

/retest

@arkodg arkodg mentioned this pull request Jun 25, 2024
Closed
@zirain
Copy link
Contributor Author

zirain commented Jun 29, 2024

/retest

@arkodg arkodg added this to the v1.1.0-rc1 milestone Jul 1, 2024
shawnh2
shawnh2 approved these changes Jul 2, 2024
View reviewed changes
Copy link
Contributor

@shawnh2 shawnh2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! One small nit.

test/e2e/base/manifests.yaml Outdated Show resolved Hide resolved
AliceProxy
AliceProxy approved these changes Jul 2, 2024
View reviewed changes
Copy link
Member

@AliceProxy AliceProxy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks

@arkodg arkodg merged commit 2ecfa06 into envoyproxy:main Jul 3, 2024
26 checks passed
@zirain zirain deleted the als branch July 3, 2024 00:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AliceProxy AliceProxy AliceProxy approved these changes

@shawnh2 shawnh2 shawnh2 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.1.0-rc1
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@zirain @AliceProxy @shawnh2 @arkodg @davidalger