Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: cookie based consistent hashing #3683

Merged
merged 2 commits into from
Jul 4, 2024
Merged

feat: cookie based consistent hashing #3683

merged 2 commits into from
Jul 4, 2024

Conversation

arkodg
Copy link
Contributor

@arkodg arkodg commented Jun 27, 2024

Fixes: #2624

@arkodg arkodg requested a review from a team as a code owner June 27, 2024 00:38
@arkodg arkodg marked this pull request as draft June 27, 2024 00:38
@arkodg arkodg added this to the v1.1.0-rc1 milestone Jun 27, 2024
@codecov Codecov
Copy link

codecov bot commented Jun 27, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 50.00000% with 10 lines in your changes missing coverage. Please review.

Project coverage is 68.99%. Comparing base (4602f6d) to head (1de8ca2).
Report is 7 commits behind head on main.

Files Patch % Lines
internal/xds/translator/route.go 44.44% 8 Missing and 2 partials ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #3683      +/-   ##
==========================================
- Coverage   69.05%   68.99%   -0.07%     
==========================================
  Files         176      176              
  Lines       21688    21739      +51     
==========================================
+ Hits        14977    14998      +21     
- Misses       5632     5659      +27     
- Partials     1079     1082       +3

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@arkodg
feat: cookie based consistent hashing
7d6a6a4 
Fixes: envoyproxy#2624

Signed-off-by: Arko Dasgupta <[email protected]>
@arkodg
add test
1de8ca2 
Signed-off-by: Arko Dasgupta <[email protected]>
@arkodg arkodg marked this pull request as ready for review July 3, 2024 23:54
zirain
zirain approved these changes Jul 4, 2024
View reviewed changes
Copy link
Contributor

@zirain zirain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, need docs and tests.

@arkodg
Copy link
Contributor Author

arkodg commented Jul 4, 2024 •
edited
Loading

LGTM, need docs and tests.

yeah added issues to track that, will pick those up and complete them by v1.1

@arkodg arkodg requested review from a team July 4, 2024 00:15
shawnh2
shawnh2 approved these changes Jul 4, 2024
View reviewed changes
Copy link
Contributor

@shawnh2 shawnh2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@zirain
Copy link
Contributor

zirain commented Jul 4, 2024

/retest

@arkodg arkodg merged commit 9f8adfb into envoyproxy:main Jul 4, 2024
26 of 27 checks passed
@arkodg arkodg deleted the cookie-hash-impl branch July 4, 2024 00:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zirain zirain zirain approved these changes

@shawnh2 shawnh2 shawnh2 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.1.0-rc1
Development

Successfully merging this pull request may close these issues.

Support Cookie based Consistent Hashing / Session Affinity
3 participants
@arkodg @zirain @shawnh2