Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: rename control-plane metrics #3727

Merged
merged 8 commits into from
Jul 3, 2024

Conversation

shawnh2
Copy link
Contributor

@shawnh2 shawnh2 commented Jul 2, 2024

What type of PR is this?

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #3684

@shawnh2 shawnh2 requested a review from a team as a code owner July 2, 2024 11:15
Copy link

codecov bot commented Jul 2, 2024

Codecov Report

Attention: Patch coverage is 34.24658% with 48 lines in your changes missing coverage. Please review.

Project coverage is 68.76%. Comparing base (ec9945a) to head (6e25023).

Files Patch % Lines
...ternal/infrastructure/kubernetes/infra_resource.go 34.28% 23 Missing ⚠️
internal/metrics/otel_metric_counter.go 0.00% 15 Missing ⚠️
internal/xds/cache/snapshotcache.go 0.00% 7 Missing ⚠️
internal/provider/kubernetes/status_updater.go 50.00% 2 Missing ⚠️
internal/message/watchutil.go 80.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3727      +/-   ##
==========================================
- Coverage   68.81%   68.76%   -0.05%     
==========================================
  Files         175      175              
  Lines       21524    21523       -1     
==========================================
- Hits        14811    14800      -11     
- Misses       5636     5647      +11     
+ Partials     1077     1076       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@shawnh2
Copy link
Contributor Author

shawnh2 commented Jul 2, 2024

will update grafana dashboard in a follow-up PR

Signed-off-by: shawnh2 <[email protected]>
@arkodg arkodg added this to the v1.1.0-rc1 milestone Jul 3, 2024
Copy link
Member

@AliceProxy AliceProxy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm good with the general good approach, but should fix CI before merging

@shawnh2
Copy link
Contributor Author

shawnh2 commented Jul 3, 2024

/retest

@zirain zirain merged commit 015e7ff into envoyproxy:main Jul 3, 2024
26 of 27 checks passed
@shawnh2 shawnh2 deleted the cp-metrics-naming branch July 3, 2024 10:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Clean up control plane metrics names
4 participants