Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: CEL Expressions for Access Logging #3739

Merged
merged 2 commits into from
Jul 5, 2024
Merged

docs: CEL Expressions for Access Logging #3739

merged 2 commits into from
Jul 5, 2024

Conversation

zirain
Copy link
Contributor

@zirain zirain commented Jul 3, 2024

fix: #3734

@zirain zirain requested a review from a team as a code owner July 3, 2024 10:30
@codecov Codecov
Copy link

codecov bot commented Jul 3, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.95%. Comparing base (de8a53d) to head (7a26463).
Report is 2 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #3739      +/-   ##
==========================================
- Coverage   69.01%   68.95%   -0.07%     
==========================================
  Files         176      176              
  Lines       21688    21687       -1     
==========================================
- Hits        14969    14954      -15     
- Misses       5638     5652      +14     
  Partials     1081     1081

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zirain
address comment
7a26463 
Signed-off-by: zirain <[email protected]>
shawnh2
shawnh2 approved these changes Jul 4, 2024
View reviewed changes
Copy link
Contributor

@shawnh2 shawnh2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@zhaohuabing
Copy link
Member

zhaohuabing commented Jul 5, 2024 •
edited
Loading

Should we also mention the metadata(httproute, gateway) in the envoy log?

@zirain
Copy link
Contributor Author

zirain commented Jul 5, 2024

Should we also mention the metadata(httproute, gateway) in the envoy log?

that should be in another pr.

@zirain zirain merged commit abb7c96 into envoyproxy:main Jul 5, 2024
27 checks passed
@zirain zirain deleted the docs-cel branch July 5, 2024 06:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zhaohuabing zhaohuabing zhaohuabing approved these changes

@shawnh2 shawnh2 shawnh2 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

docs: CEL Expressions for Access Logging
3 participants
@zirain @zhaohuabing @shawnh2