Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

e2e: zkipin tracing test #3748

Merged
merged 5 commits into from
Jul 5, 2024
Merged

e2e: zkipin tracing test #3748

merged 5 commits into from
Jul 5, 2024

Conversation

zirain
Copy link
Contributor

@zirain zirain commented Jul 4, 2024

fix: #3686

@zirain zirain requested a review from a team as a code owner July 4, 2024 05:14
Copy link

codecov bot commented Jul 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.00%. Comparing base (d6b5415) to head (61c02f9).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3748      +/-   ##
==========================================
- Coverage   69.03%   69.00%   -0.04%     
==========================================
  Files         176      176              
  Lines       21744    21744              
==========================================
- Hits        15012    15004       -8     
- Misses       5654     5660       +6     
- Partials     1078     1080       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zirain zirain force-pushed the e2e/zipkin branch 2 times, most recently from d29a0c6 to 17329da Compare July 4, 2024 06:43
@zirain
Copy link
Contributor Author

zirain commented Jul 4, 2024

wait #3749

@zirain zirain force-pushed the e2e/zipkin branch 3 times, most recently from 47f2571 to dc773d6 Compare July 4, 2024 08:14
Signed-off-by: zirain <[email protected]>
Signed-off-by: zirain <[email protected]>
Copy link
Member

@Xunzhuo Xunzhuo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@Xunzhuo Xunzhuo requested a review from a team July 5, 2024 02:35
@zirain zirain merged commit eb9163a into envoyproxy:main Jul 5, 2024
27 checks passed
@zirain zirain deleted the e2e/zipkin branch July 5, 2024 02:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add e2e test for zipkin tracing
3 participants