Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: show golang version in the version command #3750

Merged
merged 1 commit into from
Jul 4, 2024

Conversation

zhaohuabing
Copy link
Member

This PR adds golang version to the version command:

before:

ENVOY_GATEWAY_VERSION: v1.0.2
ENVOY_PROXY_VERSION: distroless-dev
GATEWAYAPI_VERSION: v1.1.0
GIT_COMMIT_ID: a3505782947c5a3da3a586e0f8e1d55d78e86bde

after:

ENVOY_GATEWAY_VERSION: v1.0.2
ENVOY_PROXY_VERSION: distroless-dev
GATEWAYAPI_VERSION: v1.1.0
GIT_COMMIT_ID: a3505782947c5a3da3a586e0f8e1d55d78e86bde
GOLANG_VERSION: go1.22.5

Signed-off-by: Huabing Zhao <[email protected]>
@zhaohuabing zhaohuabing requested a review from a team as a code owner July 4, 2024 06:48
@zhaohuabing zhaohuabing changed the title chroe: show golang version in the version command chore: show golang version in the version command Jul 4, 2024
Copy link

codecov bot commented Jul 4, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 69.02%. Comparing base (979f949) to head (a350578).
Report is 1 commits behind head on main.

Files Patch % Lines
internal/cmd/version/version.go 0.00% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3750   +/-   ##
=======================================
  Coverage   69.01%   69.02%           
=======================================
  Files         176      176           
  Lines       21719    21741   +22     
=======================================
+ Hits        14990    15007   +17     
- Misses       5650     5653    +3     
- Partials     1079     1081    +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zhaohuabing zhaohuabing merged commit 780704c into envoyproxy:main Jul 4, 2024
20 of 24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants