Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: enable lint for benchmark #3754

Merged
merged 2 commits into from
Jul 5, 2024
Merged

chore: enable lint for benchmark #3754

merged 2 commits into from
Jul 5, 2024

Conversation

zirain
Copy link
Contributor

@zirain zirain commented Jul 4, 2024

@shawnh2 please help to review the result.

@zirain zirain requested a review from a team as a code owner July 4, 2024 10:49
Copy link

codecov bot commented Jul 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.01%. Comparing base (d6b5415) to head (0dad4b5).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3754      +/-   ##
==========================================
- Coverage   69.03%   69.01%   -0.03%     
==========================================
  Files         176      176              
  Lines       21744    21744              
==========================================
- Hits        15012    15007       -5     
- Misses       5654     5659       +5     
  Partials     1078     1078              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zirain
Copy link
Contributor Author

zirain commented Jul 4, 2024

/retest

Copy link
Contributor

@shawnh2 shawnh2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! just one nit

test/benchmark/suite/render.go Outdated Show resolved Hide resolved
Signed-off-by: zirain <[email protected]>
@zirain zirain requested a review from shawnh2 July 5, 2024 01:12
@zirain zirain merged commit df5c265 into envoyproxy:main Jul 5, 2024
26 checks passed
@zirain zirain deleted the lint-bench branch July 5, 2024 02:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants