Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: camera state when hidden page is rendered #1819

Merged
merged 13 commits into from
Dec 8, 2023
Merged

fix: camera state when hidden page is rendered #1819

merged 13 commits into from
Dec 8, 2023

Commits on Dec 7, 2023

  1. Adding a tab'ed story 

    The story has a flag controlling the rendering of hidden tabs.

Add triggerHome control to mapLayer and SubsurfaceViewer stories.

Minor props re-ordering to group camera controls
    @w1nklr
    w1nklr committed Dec 7, 2023
    Configuration menu
    Copy the full SHA
    b0cff58 View commit details
    Browse the repository at this point in the history

  2. Memoize viewPortMargins and deckGLLayers

    @w1nklr
    w1nklr committed Dec 7, 2023
    Configuration menu
    Copy the full SHA
    3dc7223 View commit details
    Browse the repository at this point in the history

  3. Add effect to retrieve size from deck ref 

    React rule is not to read/modify ref during rendering.
It proved true: computations where randomly wrong until the size of the deck was extracted in the effect.
    @w1nklr
    w1nklr committed Dec 7, 2023
    Configuration menu
    Copy the full SHA
    61e6bf1 View commit details
    Browse the repository at this point in the history

  4. Move global bounding box handling to React reducer. 

    This avoids sequences of useEffect calling setState...
    @w1nklr
    w1nklr committed Dec 7, 2023
    Configuration menu
    Copy the full SHA
    16d4a22 View commit details
    Browse the repository at this point in the history

  5. Move camera computation to useMemo

    @w1nklr
    w1nklr committed Dec 7, 2023
    Configuration menu
    Copy the full SHA
    753c6cb View commit details
    Browse the repository at this point in the history

  6. Fix lint and prettier

    @w1nklr
    w1nklr committed Dec 7, 2023
    Configuration menu
    Copy the full SHA
    ec157c8 View commit details
    Browse the repository at this point in the history

  7. Fix lint on story.

    @w1nklr
    w1nklr committed Dec 7, 2023
    Configuration menu
    Copy the full SHA
    e18f86d View commit details
    Browse the repository at this point in the history

  8. Update test snapshot

    @w1nklr
    w1nklr committed Dec 7, 2023
    Configuration menu
    Copy the full SHA
    0c928bd View commit details
    Browse the repository at this point in the history

  9. Fix annoying react error message during test_correctness

    @w1nklr
    w1nklr committed Dec 7, 2023
    Configuration menu
    Copy the full SHA
    c5018f2 View commit details
    Browse the repository at this point in the history

  10. Merge branch 'master' into fix_deck

    @nilscb
    nilscb committed Dec 7, 2023
    Configuration menu
    Copy the full SHA
    57d1db9 View commit details
    Browse the repository at this point in the history

  11. Merge branch 'master' into fix_deck

    @nilscb
    nilscb committed Dec 7, 2023
    Configuration menu
    Copy the full SHA
    8e8c7de View commit details
    Browse the repository at this point in the history

  12. Fix react warning in the new story

    @w1nklr
    w1nklr committed Dec 7, 2023
    Configuration menu
    Copy the full SHA
    ec7ba46 View commit details
    Browse the repository at this point in the history

  13. Fix lint error

    @w1nklr
    w1nklr committed Dec 7, 2023
    Configuration menu
    Copy the full SHA
    825dd1b View commit details
    Browse the repository at this point in the history