Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update String#trim #316

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Update String#trim #316

wants to merge 3 commits into from
+14 −12

Commits on Aug 23, 2015

  1. Update String#trim spec compliance 

    Test for incorrect trimming of NEL, trim ZWSP (which *is* trimmable in the oldest Unicode spec ES5 targets), reduce the number of string concatenations, and more quickly determine `hasTrimWhitespaceBug` to be false in the usual pre-ES5 case.

I would change `if (typeof this === 'undefined' || this === null)` to `if (this == null)` but I don't know whether that's allowed by this library's style guide.
    @lewisje
    lewisje committed Aug 23, 2015
    Configuration menu
    Copy the full SHA
    9c87839 View commit details
    Browse the repository at this point in the history

Commits on Oct 19, 2015

  1. Merge branch 'master' into string-trim-patch

    @lewisje
    lewisje committed Oct 19, 2015
    Configuration menu
    Copy the full SHA
    65f4e7d View commit details
    Browse the repository at this point in the history

Commits on Oct 20, 2015

  1. Merge branch 'master' into string-trim-patch

    @lewisje
    lewisje committed Oct 20, 2015
    Configuration menu
    Copy the full SHA
    fe49878 View commit details
    Browse the repository at this point in the history