Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add es-x/no-regexp-duplicate-named-capturing-groups rule #146

Merged
merged 5 commits into from
Jul 1, 2024

Conversation

ota-meshi
Copy link
Member

close #142

@ota-meshi ota-meshi force-pushed the no-regexp-duplicate-named-capturing-groups branch from 2566b63 to 61ba2fd Compare June 1, 2024 06:11
@aladdin-add
Copy link
Contributor

Is it a draft as the proposal has not reached stage-4?

@ota-meshi
Copy link
Member Author

First, I am waiting for the release of acorn. It is implemented in the master branch.
https://github.com/acornjs/acorn/commits/master/

After that, we will need to change espree and regexpp.
A PR has been opened for regexpp, but if the source code of acorn changes before the release, we may make changes accordingly.
eslint-community/regexpp#195

@aladdin-add
Copy link
Contributor

the supports was added:

@ota-meshi ota-meshi marked this pull request as ready for review June 28, 2024 09:04
@ota-meshi ota-meshi requested a review from a team June 28, 2024 09:04
tests/tester.js Outdated Show resolved Hide resolved
@aladdin-add aladdin-add merged commit 5b9a5a0 into master Jul 1, 2024
13 checks passed
@aladdin-add aladdin-add deleted the no-regexp-duplicate-named-capturing-groups branch July 1, 2024 05:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add rule for RegExp duplicate named capture groups (ES2025)
2 participants