Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ThingPulse Pendrive S3 #155

Merged
merged 2 commits into from
Jun 4, 2024

Conversation

squix78
Copy link
Contributor

@squix78 squix78 commented Jun 3, 2024

Kind regards,
Daniel

@Spritetm
Copy link
Member

Spritetm commented Jun 4, 2024

Ah crap... seems like the person before you skipped a PID and the CI script didn't catch that because of a bug. Would you mind changing your MR to make one of your requested PIDs go where 0x8202 would go to fix this? If not, no issue either, I'll just burn that PID.

@squix78
Copy link
Contributor Author

squix78 commented Jun 4, 2024

All good, I moved the allocation up! Thank you

@Spritetm
Copy link
Member

Spritetm commented Jun 4, 2024

Thanks, I appreciate it! I've also fixed CI so this won't happen again.

@Spritetm Spritetm merged commit 48d8956 into espressif:main Jun 4, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants