Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(js-client): Add OP Chain support #831

Merged
merged 4 commits into from
Jul 22, 2023
Merged

feat(js-client): Add OP Chain support #831

merged 4 commits into from
Jul 22, 2023

Conversation

qbzzt
Copy link
Contributor

@qbzzt qbzzt commented Jul 12, 2023 •
edited
Loading

Closing: DEVRL-1051

@qbzzt
Copy link
Contributor Author

qbzzt commented Jul 12, 2023

Wilson Cusack
2:03 PM
I think that's good! Or "OP Stack Javascript Client SDK"

(from Slack).

So that's preapproval.

@qbzzt qbzzt marked this pull request as ready for review July 12, 2023 19:06
sbvegan
sbvegan reviewed Jul 13, 2023
View reviewed changes
Copy link
Contributor

@sbvegan sbvegan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, just the same question that I posted here: ethereum-optimism/optimism-tutorial#194.

These docs are missing ZORA and BASE

src/docs/sdk/js-client.md Outdated Show resolved Hide resolved
@sbvegan sbvegan mentioned this pull request Jul 13, 2023
Merged
@qbzzt qbzzt merged commit 2cd855f into main Jul 22, 2023
5 checks passed
@qbzzt qbzzt deleted the qbzzt/230712-other-chain-support branch July 22, 2023 03:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sbvegan sbvegan sbvegan approved these changes

@OPMattie OPMattie OPMattie approved these changes

@Nicca42 Nicca42 Awaiting requested review from Nicca42 Nicca42 is a code owner

@smartcontracts smartcontracts Awaiting requested review from smartcontracts

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@qbzzt @sbvegan @OPMattie