Fixing newick parsing #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fredericlemoine
approved these changes
Apr 29, 2024
krtab
added a commit
to krtab/gotree
that referenced
this pull request
Apr 29, 2024
Commit b959a7f was made because `test.sh` cannot run on systems where the default shell is not bash compatible (e.g. zsh). (cf evolbioinfo#23) A [shebang](https://en.wikipedia.org/wiki/Shebang_(Unix)) allows to force the use of bash to interpret the shell script. This version using `/usr/bin/env` should be the most portable.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #22.
I changed
ReadUntilSemiColonso that thelastCharvariable checks the last non space or\tcharacter in a line.All the tests should keep passing (they do on my machine).
N.B: I also changed the instructions on how to run the test script in the README.md file. My default shell is zsh, as such if I just execute
./test.shthe script fails, runningbash test.shyields the expected results.