Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(site): improve performance by replacing page content #1917

Open
wants to merge 10 commits into
base: main
Choose a base branch
from
Open

feat(site): improve performance by replacing page content #1917

wants to merge 10 commits into from

Conversation

fshovchko
Copy link
Contributor

No description provided.

@ala-n
Copy link
Collaborator

ala-n commented Sep 5, 2023

Just a small note:
If we see that the service worker is going to give us a benefit -
for the result version, it should use the existing code environment (TS + webpack).
You don't need to make a separate folder and use a plain JS single file, and it's still a client-side code.

@fshovchko fshovchko changed the title feat(gh-pages): service worker (Draft) feat(gh-pages): improve performance by replacing page content Sep 12, 2023
@fshovchko fshovchko requested review from a team, julia-murashko, dshovchko and abarmina and removed request for a team September 12, 2023 12:01
dshovchko
dshovchko reviewed Sep 14, 2023
View reviewed changes
pages/src/route/route-link.ts Outdated Show resolved Hide resolved
pages/src/route/route-link.ts Outdated Show resolved Hide resolved
pages/src/route/router-service.ts Outdated Show resolved Hide resolved
pages/src/route/router-service.ts Outdated Show resolved Hide resolved
@fshovchko fshovchko self-assigned this Sep 15, 2023
@fshovchko fshovchko marked this pull request as ready for review September 25, 2023 12:18
@codeclimate
Copy link

codeclimate bot commented Sep 28, 2023

Code Climate has analyzed commit 41e552d and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 53.0% (2.3% change).

View more on Code Climate.

@ala-n ala-n added the site Feature, enhancement or bug for demo site label Oct 27, 2023
@ala-n ala-n changed the title feat(gh-pages): improve performance by replacing page content feat(site): improve performance by replacing page content Jan 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ala-n ala-n Awaiting requested review from ala-n

@NastaLeo NastaLeo Awaiting requested review from NastaLeo

@julia-murashko julia-murashko Awaiting requested review from julia-murashko julia-murashko was automatically assigned from exadel-inc/esl-core-team

@abarmina abarmina Awaiting requested review from abarmina

@dshovchko dshovchko Awaiting requested review from dshovchko

At least 2 approving reviews are required to merge this pull request.

Assignees

@fshovchko fshovchko

Labels
site Feature, enhancement or bug for demo site
Projects
None yet
Milestone
🍀 GH Pages Redesign - 2024 (3-4 Quartal)
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@fshovchko @ala-n @dshovchko