This repository has been archived by the owner on Mar 3, 2020. It is now read-only.
Fixing errors with registration page #631
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Couldn't select a logo on Firefox, as the touch-swipe blocks the
`mouseup` event needed for `click` to work
- Issues showing an error with the password when team names are present
- The lack of an error text block caused JS errors
- The password field would not be marked in red
- `$('.el--text')[1]` would refer to the first email field,
rather than the password field
JasonTarka
force-pushed
the
login-page-js-fix
branch
from
0e2c740
to
618edd2
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
mouseupevent needed forclickto work$('.el--text')[1]would refer to the first email field,rather than the password field