Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: bpe was not included as data into package. #112

Merged
merged 1 commit into from
Jul 10, 2024

Conversation

ericschreiber
Copy link
Contributor

Hi, thanks for the cool ideas and ease of use : )

I (probably also others) just wanted to use this as a package. For the text embeddings to work, one needs to include the bpe tokenizer. This file was not included into the package.
This should be fixed and this package can be used out of different directories now with the standard package builds.

python setup.py bdist_wheel

Then install the package with pip:

pip install dist/*.whl

I hope this quick fix gets accepted 😊

Best regards, Eric

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Mar 20, 2024
@ChrisjanWust ChrisjanWust merged commit 412bbc0 into facebookresearch:main Jul 10, 2024
1 check passed
@ChrisjanWust
Copy link
Collaborator

ChrisjanWust commented Jul 10, 2024

Thanks for the contribution @ericschreiber. I've resolved some merge conflicts and merged. ImageBind should now work out-of-the-box as a package.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants