Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Change encoding to UTF-8 for opening README.md in setup.py #113

Merged
merged 1 commit into from
Jul 10, 2024

Conversation

ChoYongchae
Copy link

Thanks for nice repository!

This commit adjusts the encoding to UTF-8 for the 'open' command used to access the README.md file in the setup.py. The modification aims to ensure compatibility with the default language settings in Windows environments.

Regards,
Choyongchae

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Apr 3, 2024
@ChoYongchae
Copy link
Author

Reference (before fix):

  • Environment: Windows, Korean language setting
  • Error message:
  error: subprocess-exited-with-error

  × python setup.py egg_info did not run successfully.
  │ exit code: 1
  ╰─> [6 lines of output]
      Traceback (most recent call last):
        File "<string>", line 2, in <module>
        File "<pip-setuptools-caller>", line 34, in <module>
        File "D:\ImageBind\setup.py", line 11, in <module>
          long_description=open('README.md').read(),
      UnicodeDecodeError: 'cp949' codec can't decode byte 0xe2 in position 952: illegal multibyte sequence
      [end of output]

  note: This error originates from a subprocess, and is likely not a problem with pip.
error: metadata-generation-failed

× Encountered error while generating package metadata.
╰─> See above for output.```

@ChrisjanWust
Copy link
Collaborator

Thanks for squashing this little bug, Choyongchae. Merging now 👍

@ChrisjanWust ChrisjanWust merged commit aedc5ab into facebookresearch:main Jul 10, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants