Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Poetry setup #61

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Poetry setup #61

wants to merge 4 commits into from

Conversation

jctosta
Copy link

@jctosta jctosta commented May 24, 2023

This pull request setups Poetry build tool for ImageBind, allowing it's usage as dependency in poetry projects.

Changes

  • Poetry setup
  • Packages configuration (models/* and data)
  • Updated instructions at README.md

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label May 24, 2023
@chrisaddy
Copy link

you have imagebind in the pyproject.toml name, but if the module is named models this would fail to build right?

I think you would need to update the name, or change the module name.

The first is easier, but the second might be a better long term solution, as it would make using it in other projects more clear, i.e.,

from imagebind import ...

is probably more obvious than

from models import ...

this is what I did in my fork of imagebind: https://github.com/chrisaddy/ImageBind

All said, thanks for opening this PR, definitely want to get this in a pip installable format!

@jctosta
Copy link
Author

jctosta commented Jun 16, 2023

Hi @chrisaddy Strange, I was able to use it without any problems, I have some projects that depend on my fork and they are working correctly.

The only difference is that I had to add the following lines to the pyproject file:

packages = [
    { include = "data.py" },
    { include = "models" }
]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants