improvement: add casing version and allow for "preserved" casing words #3777
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dsinghvi
reviewed
Jun 5, 2024
| smartCasing || | ||
| casingVersion === generatorsYml.CasingVersion.V0 || | ||
| casingVersion === generatorsYml.CasingVersion.V1 | ||
| ) { |
There was a problem hiding this comment.
i would have thought that v0 would not default to smart casing?
Some context on the PR about what is v0 and what is v1 would be helpful
dsinghvi
reviewed
Jun 5, 2024
| }: { | ||
| generationLanguage: generatorsYml.GenerationLanguage | undefined; | ||
| keywords: string[] | undefined; | ||
| smartCasing: boolean; | ||
| casingVersion: generatorsYml.CasingVersion | undefined; |
There was a problem hiding this comment.
do you think we can delete smartCasing altogether and just rely on casingVersion now here?
i would have expected the code to read something like:
switch (version) {
case "v0":
// do a vanilla case
case "v1":
// handle initialisms and numbers
default:
assertNever(version)
}There was a problem hiding this comment.
So you want to have a yaml migration to move smartCasing to v0?
There was a problem hiding this comment.
I think internally in the codebase we can have casingVersion (in ir-generator for example), but externally we can listen to version first and then fall back to smart-casing -> v1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.