wip: add a getDefinition function to a fernworkspace #3784
+1,294
−1,145
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dsinghvi
reviewed
Jun 5, 2024
| }, | ||
| packageMarkers: {}, | ||
| importedDefinitions: {} | ||
| getDefinition: async (language?: generatorsYml.GenerationLanguage) => { |
There was a problem hiding this comment.
any thoughts on how to solve logging (i.e. we are going to call loadDependency multiple times now)
There was a problem hiding this comment.
just what we talked about already which is creating a silent logger to pass through
dsinghvi
reviewed
Jun 5, 2024
amckinney
approved these changes
Jun 6, 2024
dsinghvi
approved these changes
Jun 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this allows deferring the generation of the workspace until the generation language is known