Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: landing page in docs #3999

Merged
merged 2 commits into from
Jul 6, 2024
Merged

feat: landing page in docs #3999

merged 2 commits into from
Jul 6, 2024

Conversation

abvthecity
Copy link
Contributor

@abvthecity abvthecity commented Jul 6, 2024

Allow docs users to specify a landing page, which is de-attached from the navigation hierarchy.

The landing page does not show up anywhere visually (no tabs, etc.) but if the logo doesn't have a href, clicking the logo will by default open the landing page.

Also, by default the landing page has no slug, but that can be overridden.

@abvthecity abvthecity requested a review from dsinghvi as a code owner July 6, 2024 20:57
@abvthecity abvthecity merged commit 990f7ac into main Jul 6, 2024
27 checks passed
@abvthecity abvthecity deleted the ajiang/landing-page branch July 6, 2024 23:42
dsinghvi added a commit that referenced this pull request Jul 9, 2024
dsinghvi added a commit that referenced this pull request Jul 9, 2024
Revert "feat: landing page in docs (#3999)"

This reverts commit 990f7ac.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants