Enhancement: reset group offsets to a specific time #141
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previous comment appears misleading; if specialOffset is true, then the offset _was_ reset
|
thank you! will pull this in and resolve conflicts on main. do you maybe want to follow up with updates to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For partitioned topics, it's often useful to reset the group position all partitions to a specific time rather than a specific offset. This PR teaches
kt group -resetto accept a time string (as parsed by https://github.com/markusmobius/go-dateparser) in addition to the special values newest and oldest. For example,kt group -group some-group -topic some topic -reset "6 hours ago"is much more convenient than trying to figure out which offsets correspond to that time and invokingkt group -resetfor each of N partitions.Also,
kt group -reset ARGprints the resulting offsets and lags when ARG is "newest", "oldest" or a time string, rather than omitting them on the assumption that the lag is unknown. As far as I can tell the value ofspecialOffsetis unrelated to whether the offset was previously stored on the broker or not.