Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependencies that use protobufjs #7127

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Conversation

aalej
Copy link
Contributor

@aalej aalej commented May 8, 2024

Description

Fixes #7122

Update a couple of dependencies that use protobufjs

"@google-cloud/pubsub": "^3.0.1" -> "^4.0.0"
"firebase-admin": "^11.5.0", -> "^12.1.0"
"firebase-functions": "^4.3.1", -> "^5.0.1"

Ran npm update protobufjs to update the rest of the dependencies.

Scenarios Tested

N/A

Sample Commands

N/A

@aalej
Copy link
Contributor Author

aalej commented May 8, 2024

Looking into the failing tests

Copy link
Contributor

@joehan joehan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - firebase-admin/functions are just devDeps, and the only breaking change in pubsub 4.0.0 was dropping node 12 support. This is extremely low risk

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

protobufjs Prototype Pollution vulnerability
2 participants