Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix:(track.ts) if environment variables were set, use proxy agent. #7218

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

takao-s
Copy link

@takao-s takao-s commented May 24, 2024

Description

Fixed: If you run firebase login behind the proxy server , you will see "Error: An unexpected error has occurred." in your termial after a few seconds, even if you set the environment variables such as HTTP_PROXY.
Because track.ts try to fetch to the GA4 without proxy settings.

I fixed track.ts to use proxy-agent when the environment variables such as HTTP_PROXY are set.

Scenarios Tested

I manually tested ...

  1. firebase login behind the proxy with enviroment variables. -> Success
  2. firebase login behind the proxy without enviroment variables. -> Error
  3. firebase login directly connected to the Internet with enviroment variables. -> Error
  4. firebase login directly connected to the Internet without enviroment variables. -> Success

Sample Commands

Copy link

google-cla bot commented May 24, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant