Auth working in IDX? #7315
Open
Auth working in IDX? #7315
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joehan
commented
Jun 12, 2024
| @@ -52,7 +50,10 @@ async function autoAuth(options: Options, authScopes: string[]): Promise<void | | |||
| // Make sure any error here doesn't block the CLI, but log it. | |||
| logger.debug(`Error getting account credentials.`); | |||
| } | |||
|
|
|||
| if (process.env.MONOSPACE_ENV && token && clientEmail) { | |||
There was a problem hiding this comment.
Note: we should maybe replace this MONOSPACE check with a check whether clientEmail is a user email (as opposed to a service account email). IIUC, this would make ADCs set through GCloud work more consistently with some of our login flows. Likely do need to iron out some details around logout with it tho
There was a problem hiding this comment.
++ we'll need a huge rework on logout anyways i think...
hlshen
approved these changes
Jun 12, 2024
| @@ -52,7 +50,10 @@ async function autoAuth(options: Options, authScopes: string[]): Promise<void | | |||
| // Make sure any error here doesn't block the CLI, but log it. | |||
| logger.debug(`Error getting account credentials.`); | |||
| } | |||
|
|
|||
| if (process.env.MONOSPACE_ENV && token && clientEmail) { | |||
There was a problem hiding this comment.
++ we'll need a huge rework on logout anyways i think...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Scenarios Tested
Sample Commands