-
Notifications
You must be signed in to change notification settings - Fork 918
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix grammar: setup -> set up #7377
base: master
Are you sure you want to change the base?
Conversation
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Thanks for the contribution. Looks like you need to run 'npm run format', and then this should be good to go. |
Thank you! |
@@ -222,7 +222,7 @@ | |||
"eslint": "^8.56.0", | |||
"eslint-config-google": "^0.14.0", | |||
"eslint-config-prettier": "^9.1.0", | |||
"eslint-plugin-jsdoc": "^48.0.1", | |||
"eslint-plugin-jsdoc": "^48.4.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems unrelated to the typo fix - any reason for updating this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was added to the PR in the commit I had run the format command.
I can remove this from the PR.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #7377 +/- ##
=======================================
Coverage 53.82% 53.82%
=======================================
Files 388 388
Lines 26281 26281
Branches 5404 5404
=======================================
Hits 14147 14147
Misses 10866 10866
Partials 1268 1268 ☔ View full report in Codecov by Sentry. |
fixing grammar for setup -> set up