Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix grammar: setup -> set up #7377

Open
wants to merge 9 commits into
base: master
Choose a base branch
from

Conversation

jarrensj
Copy link

fixing grammar for setup -> set up

Copy link

google-cla bot commented Jun 25, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@joehan
Copy link
Contributor

joehan commented Jun 25, 2024

Thanks for the contribution. Looks like you need to run 'npm run format', and then this should be good to go.

@jarrensj
Copy link
Author

Thanks for the contribution. Looks like you need to run 'npm run format', and then this should be good to go.

Thank you!

@jarrensj jarrensj requested a review from joehan July 6, 2024 00:21
@@ -222,7 +222,7 @@
"eslint": "^8.56.0",
"eslint-config-google": "^0.14.0",
"eslint-config-prettier": "^9.1.0",
"eslint-plugin-jsdoc": "^48.0.1",
"eslint-plugin-jsdoc": "^48.4.0",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems unrelated to the typo fix - any reason for updating this?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was added to the PR in the commit I had run the format command.

I can remove this from the PR.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 53.82%. Comparing base (6039938) to head (903673a).
Report is 10 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #7377   +/-   ##
=======================================
  Coverage   53.82%   53.82%           
=======================================
  Files         388      388           
  Lines       26281    26281           
  Branches     5404     5404           
=======================================
  Hits        14147    14147           
  Misses      10866    10866           
  Partials     1268     1268           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants