Use emulator issues stream notification to initiate schema reload #7411
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rosalyntan
approved these changes
Jul 3, 2024
| const issueMessage = `Data Connect Emulator: ${issue.kind.toString()} - ${issue.message}`; | ||
| if (issue.severity === Severity.ALERT) { | ||
| vscode.window.showErrorMessage(issueMessage); | ||
| } else if (issue.severity === Severity.NOTICE) { |
There was a problem hiding this comment.
Not blocking for this PR, but I wonder if we should chat to discuss if there should be a standard way for VSCode to handle different severity levels (i.e. would you prefer the FILE_RELOAD notification to be sent with DEBUG severity level, so you can keep displaying NOTICE as a warning message?)
| ) { | ||
| const obsErrors = await getEmulatorIssuesStream(configs, fdcEndpoint); | ||
| const obsConverter = { | ||
| next(nextResponse: EmulatorIssueResponse) { | ||
| if (nextResponse.result?.issues?.length) { | ||
| for (const issue of nextResponse.result.issues) { | ||
| displayAndHandleIssue(issue, isPostgresEnabled); | ||
| console.log("HAROLD: ", issue) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.