refactor: simplify get_msr_chunks #4649
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ShadowCurse
force-pushed
the
get_msr_update
branch
2 times, most recently
from
7bb3170
to
0524244
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4649 +/- ##
=======================================
Coverage 82.08% 82.08%
=======================================
Files 255 255
Lines 31257 31267 +10
=======================================
+ Hits 25656 25666 +10
Misses 5601 5601
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
ShadowCurse
force-pushed
the
get_msr_update
branch
from
0524244
to
621d678
Compare
ShadowCurse
added
the
Status: Awaiting review
zulinx86
reviewed
Jun 21, 2024
zulinx86
reviewed
Jun 21, 2024
zulinx86
reviewed
Jun 21, 2024
ShadowCurse
force-pushed
the
get_msr_update
branch
2 times, most recently
from
32c3828
to
50630ea
Compare
ShadowCurse
force-pushed
the
get_msr_update
branch
2 times, most recently
from
99806e5
to
aea2b6b
Compare
zulinx86
reviewed
Jun 26, 2024
ShadowCurse
force-pushed
the
get_msr_update
branch
2 times, most recently
from
ac936ae
to
ddf6fab
Compare
ShadowCurse
force-pushed
the
get_msr_update
branch
from
ddf6fab
to
4abe68a
Compare
roypat
reviewed
Jul 1, 2024
ShadowCurse
force-pushed
the
get_msr_update
branch
2 times, most recently
from
4e0605d
to
54a910e
Compare
zulinx86
reviewed
Jul 2, 2024
Move logic to create single msr chunk into separate function. Also use iterators for msr indexes to remove some unneeded allocations. Signed-off-by: Egor Lazarchuk <[email protected]>
ShadowCurse
force-pushed
the
get_msr_update
branch
from
54a910e
to
36d709c
Compare
zulinx86
approved these changes
Jul 2, 2024
roypat
approved these changes
Jul 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Move logic to create single msr chunk into separate function. Also use iterators for msr indexes to remove some unneeded allocations.
Reason
Minor simplification and removal of unneeded allocations.
License Acceptance
By submitting this pull request, I confirm that my contribution is made under
the terms of the Apache 2.0 license. For more information on following Developer
Certificate of Origin and signing off your commits, please check
CONTRIBUTING.md.PR Checklist
PR.
CHANGELOG.md.TODOs link to an issue.contribution quality standards.
rust-vmm.