Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/apr 2024 api update #11

Merged
merged 10 commits into from
Jun 12, 2024
Merged

Conversation

fivetran-catfritz
Copy link
Contributor

@fivetran-catfritz fivetran-catfritz commented Jun 3, 2024

PR Overview

This PR will address the following Issue/Feature:

This PR will result in the following new package version:

  • v0.3.0: breaking due to schema changes (deleting columns)

Please provide the finalized CHANGELOG entry which details the relevant changes included in this PR:

🚨 Breaking Changes 🚨:

  • This change is made breaking since columns have been removed, since these columns have been removed in the Feb 2024 and Apr 2024 Fivetran Facebook Pages connector updates. You will need to adjust your downstream use cases accordingly.
    • Columns removed from staging model stg_facebook_pages__daily_page_metrics_total:
      • consumptions
      • content_activity
      • engaged_users
      • places_checkin_mobile
      • views_external_referrals
      • views_logged_in_total
      • views_logout
    • Columns removed from staging model stg_facebook_pages__lifetime_post_metrics_total:
      • impressions_fan_paid

Features

  • Updated documentation to reflect the current schema.

Under the Hood:

  • Incorporated the new fivetran_utils.drop_schemas_automation macro into the end of each Buildkite integration test job.
  • Updated the pull request templates.
  • Included auto-releaser GitHub Actions workflow to automate future releases.

PR Checklist

Basic Validation

Please acknowledge that you have successfully performed the following commands locally:

  • dbt run –full-refresh && dbt test
  • dbt run (if incremental models are present) && dbt test

Before marking this PR as "ready for review" the following have been applied:

  • The appropriate issue has been linked, tagged, and properly assigned
  • All necessary documentation and version upgrades have been applied
  • docs were regenerated (unless this PR does not include any code or yml updates)
  • BuildKite integration tests are passing
  • Detailed validation steps have been provided below

Detailed Validation

Please share any and all of your validation steps:

  • Columns have been removed.

If you had to summarize this PR in an emoji, which would it be?

📄

@fivetran-catfritz fivetran-catfritz self-assigned this Jun 3, 2024
@fivetran-catfritz fivetran-catfritz linked an issue Jun 4, 2024 that may be closed by this pull request
4 tasks
@@ -212,7 +190,7 @@ models:
description: The total number of views on the post longer than 10 seconds when the post was clicked to play
- name: video_views_10s_organic
description: The total number of organic views on the post longer than 10 seconds
- name: video_views_10s_paid
- name: video_views_10_s_paid
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is how it's spelled in the model, so thought it was better to update here than in the model.

Copy link
Collaborator

@fivetran-joemarkiewicz fivetran-joemarkiewicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! But let's hold off releasing until next week in case there are other considerations we should take into account with breaking changes.

@fivetran-avinash fivetran-avinash self-requested a review June 11, 2024 22:21
@fivetran-catfritz fivetran-catfritz merged commit 5ca1c38 into main Jun 12, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Facebook removed fields from all versions of the API
3 participants