Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: Adopt new Sax backend format #34

Merged
merged 2 commits into from
Jan 18, 2024
Merged

FIX: Adopt new Sax backend format #34

merged 2 commits into from
Jan 18, 2024

Conversation

jan-david-fischbach
Copy link
Collaborator

fix previous commit by manually converting to scoo.
Should probably be replaced by appropriate use of analyze_instances going forward.
@joamatab @flaport
should fix gdsfactory/gplugins#305

@flaport
Copy link
Owner

flaport commented Jan 18, 2024

Thanks @jan-david-fischbach . No need to use analyze_instances in this case as we're working with raw s-matrices (not models producing s-matrices). Your solution is pretty good. Only extra change I made is to pin sax>=0.11.1.

@flaport flaport merged commit 4d4bcea into main Jan 18, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

meow tests failing
2 participants