Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add progress bar for EME #1772

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Add progress bar for EME #1772

wants to merge 1 commit into from

Conversation

caseyflex
Copy link
Contributor

@caseyflex caseyflex commented Jun 18, 2024

Together with the backend PR, this adds a progress bar for EME simulations.

@caseyflex caseyflex marked this pull request as draft June 18, 2024 12:49
@caseyflex caseyflex marked this pull request as ready for review July 11, 2024 12:15
Copy link
Collaborator

@momchil-flex momchil-flex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this is great! In my tests it looked a little uneven in the progress (I mean a bit uneven time between updates) but it's nice to have something happening. :)

tidy3d/web/api/webapi.py Outdated Show resolved Hide resolved
@caseyflex
Copy link
Contributor Author

Thanks, this is great! In my tests it looked a little uneven in the progress (I mean a bit uneven time between updates) but it's nice to have something happening. :)

Yeah, it's definitely not entirely even, just based on counting steps, but should be better than nothing. We can update it to use the time estimation later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants