Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Delimiter and Casing options for parsing #113

Open
wants to merge 11 commits into
base: master
Choose a base branch
from
Open

Add Delimiter and Casing options for parsing #113

wants to merge 11 commits into from

Conversation

BlakeHensleyy
Copy link

@BlakeHensleyy BlakeHensleyy commented Jul 5, 2024 •
edited by daipom
Loading

Add the options description_prefix_word_delimiter, description_word_delimiter, and downcase_description_keys. The inclusion of these options will make it possible to align the key naming scheme with the rest of an organizations logs.

  • description_prefix_word_delimiter changes the delimiter between the parent_key and the key.
    • Example: the . in subject.account_name
  • description_word_delimiter changes the delimiter between the words of the key
    • Example: the _ in subject.account_name
  • downcase_description_keys sets all the letters of the key to lowercase.
    • Feel free to come up with better parameter names, this is the best I could come up with.

(This pr is replacing #112. The updates to CHANGLOG and README were made by mistake and can be ignored.)

Related issue:

Note: This PR fixes the issue partially. To fix the issue completely, we need to take Data Name of EventData.)

BlakeHensleyy and others added 11 commits July 5, 2024 11:03
@BlakeHensleyy
Add Params for downcasing and delimeters for description parsing.
9469663 
Signed-off-by: Blake Hensley <[email protected]>
@BlakeHensleyy
Edit README
2e0f7aa 
Signed-off-by: Blake Hensley <[email protected]>
@BlakeHensleyy
Update CHANGELOG.md
7d2bc2c 
Signed-off-by: Blake Hensley <[email protected]>
@BlakeHensleyy
0.8.4
3cb73f7 
Signed-off-by: Blake Hensley <[email protected]>
@BlakeHensleyy
Update README.md
f1b7e31 
Signed-off-by: Blake Hensley <[email protected]>
@BlakeHensleyy
Update CHANGELOG.md
e88df16 
Signed-off-by: Blake Hensley <[email protected]>
@BlakeHensleyy
0.8.3
ff413dc 
Signed-off-by: Blake Hensley <[email protected]>
@BlakeHensleyy @daipom
Update lib/fluent/plugin/in_windows_eventlog2.rb
0d9c532 
`key=` not needed

Co-authored-by: Daijiro Fukuda <[email protected]>
Signed-off-by: Blake Hensley <[email protected]>
@BlakeHensleyy @daipom
Update lib/fluent/plugin/in_windows_eventlog2.rb
31bbaf0 
prefix_word to key

Co-authored-by: Daijiro Fukuda <[email protected]>
Signed-off-by: Blake Hensley <[email protected]>
@BlakeHensleyy
Created a draft of the test for this feature.
be968bd 
Signed-off-by: Blake Hensley <[email protected]>
@BlakeHensleyy
Fix commit sign-offs
76a6e4b 
Signed-off-by: Blake Hensley <[email protected]>
@daipom daipom self-requested a review July 8, 2024 01:07
daipom
daipom approved these changes Jul 8, 2024
View reviewed changes
Copy link
Contributor

@daipom daipom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@daipom daipom linked an issue Jul 8, 2024 that may be closed by this pull request
Parsing Keys from EventData #110
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daipom daipom daipom approved these changes

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Parsing Keys from EventData
2 participants
@BlakeHensleyy @daipom