Fix build failure of windows-ltsc2019 image #358
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Takuro Ashie <[email protected]>
Recent chocolatey requires .NET 4.8 but servercore:ltsc-2019 image doesn't include it. In addition, when we try to install it, it requires reboot. Therefore it's detected as installation failure. ``` Installing 'C:\Users\CONTAI~1\AppData\Local\Temp\ndp48-x86-x64-allos-enu.exe' - this may take awhile with no output. .NET Framework 4.8 was installed, but a reboot is required. Please reboot the system and try to install/upgrade Chocolatey again. ``` Signed-off-by: Takuro Ashie <[email protected]>
Signed-off-by: Takuro Ashie <[email protected]>
cosmo0920
reviewed
Jul 20, 2023
cosmo0920
approved these changes
Jul 20, 2023
|
Thanks for your review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recent chocolatey requires .NET 4.8 but
servercore:ltsc-2019image doesn't include it. In addition, when we try to install it, it requires reboot. Therefore it's detected as installation failure.So this PR replace the base image with
mcr.microsoft.com/dotnet/framework/runtime:4.8to fix this issue.