Sync with recent upstream image #372
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
checking test... |
|
I've forgot to fix test. |
|
Now it should pass. |
|
locally checked, it passed. |
|
Oops, I've forgot to commit local change. |
ashie
reviewed
Jan 15, 2024
kenhys
force-pushed
the
rebuild
branch
2 times, most recently
from
8336c58
to
2b1b9b5
Compare
Change base image because: * Use stable image instead of old-stable one because there is a bit delay to be shipped updates from upstream. (EOL of bullseye is around July, 2024) * fluent-package LTS adopts Ruby 3.2 by default. * Use alpine:3.19 to use Ruby 3.2. Closes: #371 NOTE: Update linux containers at first. Signed-off-by: Kentaro Hayashi <[email protected]>
These packages are not needed for runtime. Before: dpkg -l | grep 'dev:amd64' ii libc6-dev:amd64 2.36-9+deb12u3 ii libcrypt-dev:amd64 1:4.4.33-2 ii libffi-dev:amd64 3.4.4-1 ii libgmp-dev:amd64 2:6.2.1+dfsg1-1.1 ii libnsl-dev:amd64 1.3.0-2 ii libssl-dev:amd64 3.0.11-1~deb12u2 ii libtirpc-dev:amd64 1.3.3+ds-1 ii libyaml-dev:amd64 0.2.5-1 ii linux-libc-dev:amd64 6.1.69-1 ii zlib1g-dev:amd64 1:1.2.13.dfsg-1 After: dpkg -l | grep dev ii libblkid1:amd64 2.38.1-5+b1 ii libgpg-error0:amd64 1.46-1 ii libmount1:amd64 2.38.1-5+b1 ii libudev1:amd64 252.19-1~deb12u1 Signed-off-by: Kentaro Hayashi <[email protected]>
Signed-off-by: Kentaro Hayashi <[email protected]>
|
kicked build trigger now. |
|
BTW Ruby 3.2 for Windows doesn't exist in Chocolatey repository: |
|
Oops, failed build armhf and arm64 unexpectedly. https://hub.docker.com/repository/docker/fluent/fluentd/builds |
|
It seems that |
kenhys
added a commit
to kenhys/fluentd-docker-image
that referenced
this pull request
Jul 10, 2024
fluent#372 Above pull request introduces "apt-get purge '*-dev'", it is intended to remove only needless development packages, but actually --auto-remove removes also runtime packages. This behavior is not intended at all, so drop --auto-remove option. Signed-off-by: Kentaro Hayashi <[email protected]>
kenhys
added a commit
to kenhys/fluentd-docker-image
that referenced
this pull request
Jul 10, 2024
fluent#372 Above pull request introduces "apt-get purge '*-dev'", it is intended to remove only needless development packages, but actually --auto-remove removes also runtime packages. This behavior is not intended at all, so drop --auto-remove option. Signed-off-by: Kentaro Hayashi <[email protected]>
kenhys
added a commit
to kenhys/fluentd-docker-image
that referenced
this pull request
Jul 10, 2024
fluent#372 Above pull request introduces "apt-get purge '*-dev'", it is intended to remove only needless development packages, but actually --auto-remove removes also runtime packages. This behavior is not intended at all, so do not apply --auto-remove when purging '*-dev'. Signed-off-by: Kentaro Hayashi <[email protected]>
kenhys
added a commit
to kenhys/fluentd-docker-image
that referenced
this pull request
Jul 10, 2024
fluent#372 Above pull request introduces "apt-get purge '*-dev'", it is intended to remove only needless development packages, but actually --auto-remove removes also runtime packages. This behavior is not intended at all, so do not apply --auto-remove when purging '*-dev'. Signed-off-by: Kentaro Hayashi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change base image because:
there is a bit delay to be shipped updates from upstream.
(EOL of bullseye is around July, 2024)
Closes: #371
NOTE: Update linux containers at first.