Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wjl #4039

Merged
merged 2 commits into from
Jun 27, 2024
Merged

wjl #4039

merged 2 commits into from
Jun 27, 2024

Conversation

wjlwjlwjlwjlwjlwjlwjl
Copy link
Contributor

@wjlwjlwjlwjlwjlwjlwjl wjlwjlwjlwjlwjlwjlwjl commented May 6, 2024

Ⅰ. Describe what this PR does

Fixed #4040
This pr is to corrected "transfromer" to "transformers" of file pkg\ddc\goosefs\load_data.go:19:47:

Ⅱ. Does this pull request fix one issue?

fixes #XXXX

Ⅲ. List the added test cases (unit test/integration test) if any, please explain if no tests are needed.

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

Signed-off-by: wjlwjlwjlwjlwjlwjlwjl <[email protected]>
Copy link

fluid-e2e-bot bot commented May 6, 2024

Hi @wjlwjlwjlwjlwjlwjlwjl. Thanks for your PR.

I'm waiting for a fluid-cloudnative member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link

sonarcloud bot commented May 6, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@LiYuhang9527
Copy link
Contributor

/lgtm

Copy link

fluid-e2e-bot bot commented May 21, 2024

@LiYuhang9527: changing LGTM is restricted to collaborators

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link
Collaborator

@cheyang cheyang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

Copy link

fluid-e2e-bot bot commented Jun 24, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: cheyang

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@cheyang cheyang merged commit 88ce48f into fluid-cloudnative:master Jun 27, 2024
6 checks passed
cheyang added a commit to Ametsuji-akiya/fluid that referenced this pull request Jul 16, 2024
Signed-off-by: wjlwjlwjlwjlwjlwjlwjl <[email protected]>
Co-authored-by: cheyang <[email protected]>
Signed-off-by: cheyang <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[DOC] fix typo in load_data.go
3 participants