dataset support pvc storageSize #4178
Conversation
|
Hi @wangshulei098. Thanks for your PR. I'm waiting for a fluid-cloudnative member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
wangshulei098
force-pushed
the
feat/storagesize
branch
from
2f0640c
to
8b67eea
Compare
wangshulei098
force-pushed
the
feat/storagesize
branch
6 times, most recently
from
650163e
to
23e0877
Compare
api/v1alpha1/dataset_types.go
Outdated
|
|
||
| // StorageCapacity is the storage size of generated PVC and PV | ||
| // +optional | ||
| StorageCapacity resource.Quantity `json:"storageCapacity,omitempty"` |
There was a problem hiding this comment.
Do we have to add a new field to the Dataset CRD? StorageCapacity is just informational in Fluid, might be confusing with some other concept like tieredstore.quota. How about following PR#3146? So we can override storage capacity with a given annotation on Dataset? WDYT @wangshulei098 @cheyang
There was a problem hiding this comment.
Good point. Agree. I think we can use the annotation key pvc.fluid.io/resources.request.storageSize to specify the desired storage size for the PVC. This key is descriptive and aligns with the Kubernetes convention for resource requests.
It can provide flexibility to extend the customization of PVC.
There was a problem hiding this comment.
ok,I will change it
There was a problem hiding this comment.
we have used “pvc.fluid.io/resources.requests.storage” as the annotation key on Dataset to specify the desired storage size for the generated PVC. If not set, or if the storage size format is incorrect, it will be set to the default value of 100Pi.
wangshulei098
changed the title
wangshulei098
force-pushed
the
feat/storagesize
branch
from
23e0877
to
429b3e9
Compare
wangshulei098
changed the title
wangshulei098
force-pushed
the
feat/storagesize
branch
from
429b3e9
to
19281c4
Compare
wangshulei098
force-pushed
the
feat/storagesize
branch
from
19281c4
to
d073198
Compare
wangshulei098
force-pushed
the
feat/storagesize
branch
from
d073198
to
269b438
Compare
Signed-off-by: wangshulei098 <[email protected]>
wangshulei098
force-pushed
the
feat/storagesize
branch
from
269b438
to
f332295
Compare
|
/test fluid-e2e |
|
@wangshulei098 Thanks for your contributions! @TrafalgarZZZ please also take a look. Thanks. |
|
@wangshulei098 Would you mind developing document for this? Thanks. It can be next PR. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cheyang, TrafalgarZZZ The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: wangshulei098 <[email protected]> Signed-off-by: cheyang <[email protected]>
Ⅰ. Describe what this PR does
The generated PVC and PV have a fixed size of 100 Pi and cannot be changed. In a namespace with a Resourcequota set for storage, it is not possible to create such large PV and PVC. Therefore, the size needs to be configurable.
Ⅱ. Does this pull request fix one issue?
fixes #4177
Ⅲ. List the added test cases (unit test/integration test) if any, please explain if no tests are needed.
Ⅳ. Describe how to verify it
“pvc.fluid.io/resources.requests.storage” as the annotation key on Dataset to specify the desired storage size for the generated PVC. If not set, or if the storage size format is incorrect, it will be set to the default value of 100Pi.
Ⅴ. Special notes for reviews