WIP: Re tangle readtheorg CSS and debug font Awesome icon display #114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposition for discussion around pull request #108
The directive "font-family: inherit" prevented Awesome icon to be displayed properly in ".fa" and "#content .admonition-title" elements -> directive removed in styles/readtheorg/readtheorg.org lines 714-715.
BUT it seems that previous changes of styles/readtheorg/css/readtheorg.css were directly performed in this file and not by tangling styles/readtheorg/readtheorg.org -> many other new changes appeared when I tangled with Org-mode. Several are welcomed to debug display of Awesome icons (directives "font-family:FontAwesome;" lines 684 and 1126) but I can not figure out the effect of others.